Skip to content

[java] UnitTestShouldIncludeAssert - consider SoftAssertionsExtension#5334

Merged
jsotuyod merged 5 commits intopmd:mainfrom
adangel:issue-4113
Nov 22, 2024
Merged

[java] UnitTestShouldIncludeAssert - consider SoftAssertionsExtension#5334
jsotuyod merged 5 commits intopmd:mainfrom
adangel:issue-4113

Conversation

@adangel
Copy link
Copy Markdown
Member

@adangel adangel commented Nov 14, 2024

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.8.0 milestone Nov 14, 2024
@ghost
Copy link
Copy Markdown

ghost commented Nov 14, 2024

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 2 new violations, 0 new errors and 0 new configuration errors,
removes 4 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

Copy link
Copy Markdown
Member

@jsotuyod jsotuyod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jsotuyod jsotuyod merged commit c23af55 into pmd:main Nov 22, 2024
@adangel adangel deleted the issue-4113 branch November 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] JUnitTestsShouldIncludeAssert - false positive with SoftAssertionsExtension

2 participants