Skip to content

Cleanup remaining experimental and deprecated API#4811

Merged
adangel merged 42 commits into
pmd:masterfrom
adangel:issue-4349-cleanup-deprecations
Feb 22, 2024
Merged

Cleanup remaining experimental and deprecated API#4811
adangel merged 42 commits into
pmd:masterfrom
adangel:issue-4349-cleanup-deprecations

Conversation

@adangel

@adangel adangel commented Feb 1, 2024

Copy link
Copy Markdown
Member

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Feb 1, 2024
@adangel adangel changed the title Issue 4349 cleanup deprecations Cleanup remaining experimental and deprecated API Feb 1, 2024
@ghost

ghost commented Feb 1, 2024

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

CpdLanguageProperties#DEFAULT_SKIP_BLOCKS_PATTERN
BaseAntlrNode#joinTextToken
Node#getNthParent
Node#getFirstChildOfType
Node#getParentsOfType
Node#findChildrenOfType
Node#findDescendantsOfType
Node#getFirstChildOfType
Node#getFirstDescendantOfType
Node#hasDescendantOfType
FileCollector#addZipFile
TextDocument#readOnlyString
TextFile#dataSourceCompat
AbstractRule#deepCopyValuesTo
AbstractRule#addRuleChainVisit
AbstractRule#addViolation
AbstractRule#addViolationWithMessage
RuleReference#setRuleSetReference
RuleReference#hasOverriddenProperty
Language#getTerseName
LanguageModuleBase#getTerseName
LanguageRegistry#getLanguage
LanguageRegistry#findLanguageByTerseName
LanguageRegistry#findByExtension
AbstractPropertySource#propertyDescriptors (private now)
AbstractPropertySource#propertyValuesByDescriptor (private now)
AbstractPropertySource#copyPropertyDescriptors
AbstractPropertySource#copyPropertyValues
Reportable#getBeginLine
Reportable#getBeginColumn
Reportable#getEndLine
Reportable#getEndColumn
DataSource
FileDataSource
ReaderDataSource
ZipDataSource
CollectionUtil#invertedMapFrom
CollectionUtil#mapFrom
…iguration

AbstractConfiguration#setIgnoreFilePath
AbstractConfiguration#setInputFilePath
AbstractConfiguration#setInputPaths
AbstractConfiguration#setInputUri
PMDConfiguration#prependClasspath
PMDConfiguration#getRuleSets
PMDConfiguration#setRuleSets
PMDConfiguration#setReportFile
PMDConfiguration#getReportFile
RuleSetLoader#toFactory
RuleViolation#getPackageName
RuleViolation#getClassName
RuleViolation#getMethodName
RuleViolation#getVariableName
AbstractPackageNameModuleDirective#getImage
AbstractTypeDeclaration#getImage
ASTAnnotation#getAnnotationName
ASTClassType#ASTClassType(String)
ASTClassType#getImage
ASTClassType#isReferenceToClassSameCompilationUnit
ASTFieldDeclaration#getVariableName
ASTLiteral#is_xxx_Literal
ASTMethodDeclaration#getMethodName
ASTMethodReference#getImage
ASTModuleName#getImage
ASTPrimitiveType#getImage
ASTType#getTypeImage
ASTType#getArrayDepth
ASTType#isPrimitiveType #isArrayType #isClassOrInterfaceType
ASTTypeDeclaration#getImage
ASTUnaryExpression#isPrefix
ASTVariableId#getImage
ASTVariableId#getVariableName
JavaComment#getImage
JavaNode#jjtAccept
JavaParserVisitor
JavaParserVisitorAdapter
ModifierOwner#isFinal #isAbstract ... #isPublic ...
TypeNode#getType
- HTML support and Kotlin support no more experimental
- The only left over experimental APIs are java preview features
@adangel adangel mentioned this pull request Feb 9, 2024
55 tasks
@adangel

adangel commented Feb 10, 2024

Copy link
Copy Markdown
Member Author

This is finally ready as well.

@adangel adangel marked this pull request as ready for review February 10, 2024 13:20
@adangel adangel added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label Feb 10, 2024
@adangel adangel merged commit 9e71e36 into pmd:master Feb 22, 2024
@adangel adangel deleted the issue-4349-cleanup-deprecations branch February 22, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] Cleanup remaining experimental and deprecated API

1 participant