Skip to content

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer#4797

Merged
adangel merged 3 commits into
pmd:masterfrom
adangel:lexexception-cpdlexer
Feb 2, 2024
Merged

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer#4797
adangel merged 3 commits into
pmd:masterfrom
adangel:lexexception-cpdlexer

Conversation

@adangel

@adangel adangel commented Jan 11, 2024

Copy link
Copy Markdown
Member

Describe the PR

  • Rename TokenMgrError to LexException
  • Rename Tokenizer to CpdLexer
  • Rename various *Tokenizer classes to *CpdLexer classes for consistency.

it's small; it can be considered as cleanup

Turns out, this was bigger than expected... but done now

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.0.0 milestone Jan 11, 2024
@adangel adangel mentioned this pull request Jan 11, 2024
55 tasks
@ghost

ghost commented Jan 11, 2024

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added the in:cpd Affects the copy-paste detector label Jan 11, 2024
@adangel adangel merged commit fa97cff into pmd:master Feb 2, 2024
@adangel adangel deleted the lexexception-cpdlexer branch February 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:cpd Affects the copy-paste detector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] Rename TokenMgrError to LexException, Tokenizer to CpdLexer

1 participant