Skip to content

[core] Remove ruleset compatibility filter (RuleSetFactoryCompatibili…#4795

Merged
adangel merged 1 commit into
pmd:masterfrom
adangel:remove-ruleset-factory-compatibility
Feb 2, 2024
Merged

[core] Remove ruleset compatibility filter (RuleSetFactoryCompatibili…#4795
adangel merged 1 commit into
pmd:masterfrom
adangel:remove-ruleset-factory-compatibility

Conversation

@adangel

@adangel adangel commented Jan 11, 2024

Copy link
Copy Markdown
Member

…ty) and CLI option --no-ruleset-compatibility

Describe the PR

Note, this is a breaking change. This functionality wasn't deprecated in PMD 6, but since PMD 7 is a major version change, this is ok.

I added some parts in pmd-compat6, maybe it's needed there.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

…ty) and CLI option `--no-ruleset-compatibility`

Fixes pmd#4314
Closes pmd#4378
@adangel adangel added this to the 7.0.0 milestone Jan 11, 2024
@adangel adangel mentioned this pull request Jan 11, 2024
55 tasks
@ghost

ghost commented Jan 11, 2024

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel added is:feature-removal Remove an unneeded unused feature in:ruleset-xml About the ruleset schema/parser labels Jan 11, 2024
@adangel adangel merged commit a76ec34 into pmd:master Feb 2, 2024
@adangel adangel deleted the remove-ruleset-factory-compatibility branch February 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:ruleset-xml About the ruleset schema/parser is:feature-removal Remove an unneeded unused feature

Projects

None yet

1 participant