[core] Remove support for deprecated rule set references notation#4786
Merged
adangel merged 3 commits intoFeb 2, 2024
Merged
Conversation
The old notation <lang>-<ruleset> is not supported anymore. It is now interpreted as a ruleset reference without a ruleset and just referencing a single rule. Also the release number notation is not supported anymore. Since RuleSetReferenceId is Internal+Deprecated, no API changes. Clarified External/Internal: A RuleSetReference is either absolute (RuleSet is known) or relative (RuleSet is not known). Fixes pmd#4313
Generated by 🚫 Danger |
Member
|
Should we remove the old release ruleset too? |
Member
Author
Eventually yes. I don't think, anyone has ever used these "rulesets/releases/xyz.xml" rulesets. And we anyway have a "since" attribute for each rule, so these release rulesets actually don't provide any additional information. But we not only have these internal rulesets, we have many old (from PMD 5 !!) rulesets like "basic.xml" etc. These have been deprecated with PMD 6 and we finally can remove them as well. However, I'd prefer to do this in a separate PR. -> #4796 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
The old notation - is not supported anymore. It is now interpreted as a ruleset reference without a ruleset and just referencing a single rule. Also the release number notation is not supported anymore.
Since RuleSetReferenceId is Internal+Deprecated, no API changes. Clarified External/Internal: A RuleSetReference is either absolute (RuleSet is known) or relative (RuleSet is not known).
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)