[apex] Fixes for experimental apex parser#4739
Merged
adangel merged 18 commits intoJan 12, 2024
Merged
Conversation
This must not be called in multiple threads as we otherwise stop logging to System.err.
Generated by 🚫 Danger |
For empty catch blocks, there is the separate rule EmptyCatchBlock. EmptyStatementBlock shouldn't report these. Refs pmd#4722
now the reported violations are correct: each if block is reported. With Apex Jorje, the line numbers of the second if block were wrong and two violations on the same line were reported.
Using now FieldDeclarations instead of Fields for report location. Refs pmd#4722
Using now FieldDeclarations instead of Fields for report location. Refs pmd#4722
Interface methods are implicit public and abstract Refs pmd#4722
Note: Apex Jorje variant didn't consider comments for fields at all. Refs pmd#4722
Note: previously, there was no space between type params, now there is. Refs pmd#4722
This should fix some of the parsing errors.
This should include the fix for pmd/pmd-regression-tester#121
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR