Skip to content

[java] ImmutableField: Remove deprecated property "ignoredAnnotations"#4489

Merged
jsotuyod merged 1 commit into
pmd:masterfrom
adangel:java-immutable-field-ignoredannot
Apr 22, 2023
Merged

[java] ImmutableField: Remove deprecated property "ignoredAnnotations"#4489
jsotuyod merged 1 commit into
pmd:masterfrom
adangel:java-immutable-field-ignoredannot

Conversation

@adangel

@adangel adangel commented Apr 20, 2023

Copy link
Copy Markdown
Member

Describe the PR

As figured out in #4474, the property ignoredAnnotations is unfortunately not deprecated anymore in 7.0.0-rc1. So that we don't forget to remove this property - because it is indeed deprecated since 6.52.0 - let's just remove it immediately.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the is:feature-removal Remove an unneeded unused feature label Apr 20, 2023
@adangel adangel added this to the 7.0.0 milestone Apr 20, 2023
@ghost

ghost commented Apr 20, 2023

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger


#### Rule Changes
* {% rule "java/design/ImmutableField" %}: the property `ignoredAnnotations` has been removed. The property was
deprecated since PMD 6.52.0.

This comment was marked as outdated.

@jsotuyod jsotuyod merged commit c487043 into pmd:master Apr 22, 2023
@adangel adangel deleted the java-immutable-field-ignoredannot branch April 22, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:feature-removal Remove an unneeded unused feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants