Skip to content

[doc] Update release notes for PMD 7.0.0-rc1#4373

Merged
adangel merged 24 commits into
pmd:masterfrom
adangel:pmd7-update-release-notes
Mar 23, 2023
Merged

[doc] Update release notes for PMD 7.0.0-rc1#4373
adangel merged 24 commits into
pmd:masterfrom
adangel:pmd7-update-release-notes

Conversation

@adangel

@adangel adangel commented Jan 30, 2023

Copy link
Copy Markdown
Member

Preview: https://github.com/adangel/pmd/blob/pmd7-update-release-notes/docs/pages/release_notes.md
and https://github.com/adangel/pmd/blob/pmd7-update-release-notes/docs/pages/release_notes_pmd7.md

Describe the PR

The goal is to complete the release notes for PMD 7.0.0-rc1.

@adangel adangel added this to the 7.0.0 milestone Jan 30, 2023
@ghost

ghost commented Jan 30, 2023

Copy link
Copy Markdown
1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel adangel mentioned this pull request Feb 10, 2023
8 tasks
@adangel adangel force-pushed the pmd7-update-release-notes branch from ba4b970 to d9bc265 Compare February 10, 2023 12:37

@jsotuyod jsotuyod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also probably explicitly mention that we split away CLI into pmd-cli and Ant into pmd-ant, which were originally part of pmd-core… most integrations are probably relying on either of them (and I'd expect specially on Ant, ie: Gradle)…

Maybe a dedicated section named Notes for integrators, reinforcing that, as a major release, this is a major rewrite, and we did these changes, along with removing the old PMD class, and explicitly marking which classes are internal and subject to change and which not, and therefore expect all integrators to require some level of change to adapt, and guide people to look at the deprecations notes for more details.

Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated

@oowekyala oowekyala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had that pending

Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
@adangel adangel force-pushed the pmd7-update-release-notes branch from 58b4c1a to 0ece932 Compare February 28, 2023 18:30
@adangel adangel mentioned this pull request Mar 2, 2023
55 tasks
@adangel

adangel commented Mar 2, 2023

Copy link
Copy Markdown
Member Author

FYI - I've created the gif using the following commands:

curl -L -o jdk-master.zip https://github.com/openjdk/jdk/archive/refs/heads/master.zip
unzip jdk-master.zip
export PMD_JAVA_OPTS="-Dorg.slf4j.simpleLogger.log.net.sourceforge.pmd=off"
pmd check -R rulesets/java/quickstart.xml -d jdk-master/src/java.base -f text --cache pmd.cache --report-file jdk-report.txt

Record screen cast with https://github.com/EasyScreenCast/EasyScreenCast (a gnome3 extension)
Convert webm to gif: https://engineering.giphy.com/how-to-make-gifs-with-ffmpeg/

ffmpeg -i pmd7-demo.webm -filter_complex "[0:v] fps=12,scale=960:-1,split [a][b];[a] palettegen [p];[b][p] paletteuse" pmd7-demo.gif

@adangel adangel added the in:documentation Affects the documentation [doc] label Mar 2, 2023
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
Comment thread docs/pages/7_0_0_release_notes.md Outdated
@adangel adangel changed the base branch from pmd/7.0.x to master March 3, 2023 17:42
@adangel adangel force-pushed the pmd7-update-release-notes branch from db8e491 to c267809 Compare March 9, 2023 09:18

@adangel adangel left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, we should create two release notes pages: Our usual "release_notes.md" and additionally a "release_notes_PMD7.md".
The reason is, that it becomes longer and longer.

The usual "release_notes.md", which will also be used for the release notes on GitHub Releases, should IMHO be a bit shorted and mention each topic with one or two sentences and point to a more detailed section in the other release note page. It should be concise and just have a pointer to the details, if someone is interested.

The new "release_notes_PMD7.md" would then be longer and contain all the details. The page title could be "Detailed Release Notes for PMD7". E.g. it also contains the list of deprecated APIs we collected from all the PMD6 releases - these are currently in "next_major_development.md".
The page could also serve as a migration guide (#4294) or at least be the basis for such a guide.

Comment thread docs/pages/release_notes.md Outdated
Comment thread docs/pages/release_notes.md Outdated
adangel added 2 commits March 16, 2023 08:30
- fix baseurl
- fix "pmd designer" call
- clarify release candidates
Main release notes are much shorter.
The full details is in a separate page.
Started to migrated Java Clean Changes from wiki.
@adangel adangel marked this pull request as ready for review March 16, 2023 10:06
@adangel

adangel commented Mar 16, 2023

Copy link
Copy Markdown
Member Author

IMHO this is now ready.

I've made the main release notes a bit smaller and more concise: https://github.com/adangel/pmd/blob/pmd7-update-release-notes/docs/pages/release_notes.md

There's now a second page, which contains the full details: https://github.com/adangel/pmd/blob/pmd7-update-release-notes/docs/pages/release_notes_pmd7.md

This second page was originally the "next_major_development" page - I've merged the contents. It's not fully fledged out yet for Java, but I think, we can finish this with the next RCs.

[skip ci]

Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
@adangel adangel merged commit 78a7a5a into pmd:master Mar 23, 2023
@adangel adangel deleted the pmd7-update-release-notes branch March 23, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in:documentation Affects the documentation [doc]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants