Skip to content

[java] ClassWithOnlyPrivateConstructorsShouldBeFinal: Exclude lombok annotations#4192

Merged
adangel merged 1 commit into
pmd:masterfrom
adangel:issue-4188-ClassWithOnlyPrivateConstructorsShouldBeFinal
Nov 25, 2022
Merged

[java] ClassWithOnlyPrivateConstructorsShouldBeFinal: Exclude lombok annotations#4192
adangel merged 1 commit into
pmd:masterfrom
adangel:issue-4188-ClassWithOnlyPrivateConstructorsShouldBeFinal

Conversation

@adangel

@adangel adangel commented Nov 4, 2022

Copy link
Copy Markdown
Member

Describe the PR

Excludes constructor related lombok annotations (NoArgsConstructor, AllArgsConstructor, RequiredArgsConstructor)

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.52.0 milestone Nov 4, 2022
@ghost

ghost commented Nov 4, 2022

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel merged commit 7d954dc into pmd:master Nov 25, 2022
@adangel adangel deleted the issue-4188-ClassWithOnlyPrivateConstructorsShouldBeFinal branch November 25, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] ClassWithOnlyPrivateConstructorsShouldBeFinal false positive with Lombok's @NoArgsConstructor

1 participant