Downgrade slf4j to 1.7.36#4023
Conversation
Generated by 🚫 Danger |
|
I support the idea of not using non-GA dependencies. Having said that, I don't really like the idea of downstream projects (ie: Sonar) conditioning our usage of libraries. We are otherwise conditioned (and forced) by them on when to upgrade to another major (and due to backwards compatibility issues, there is a good chance the 'when' is actually 'never' for them). Moreover, we may find other downstream projects following a separate schedule. I see two possible ways forward:
|
|
I'd rather be pragmatic here - especially as it is logging, which is a cross-cutting concern. I'm not sure if there is even a proper way to do classloader isolation, if every library's log should end up in the same log channel (and sonar already seems to isolate the dependencies of the plugins with the only exception being slf4j). Creating an own logging abstraction/wrapper doesn't seem to be a good idea either, see https://www.slf4j.org/faq.html#optional_dependency So I'd acknowledge that logging is an edge case and simply downgrade. It's more important for me, that PMD is working in different environments than insisting on using slf4j2. |
The test run in IntelliJ will be fixed by pmd#4032
Describe the PR
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)