Skip to content

[java] ImmutableField: Ignore @Value (Spring) and @Captor (Mockito)#4002

Merged
adangel merged 1 commit into
pmd:masterfrom
jjlharrison:master
Jun 8, 2022
Merged

[java] ImmutableField: Ignore @Value (Spring) and @Captor (Mockito)#4002
adangel merged 1 commit into
pmd:masterfrom
jjlharrison:master

Conversation

@jjlharrison

@jjlharrison jjlharrison commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Describe the PR

Ignore fields annotated with @Value (Spring) or @Captor (Mockito) to match ignores for other annotations from the same frameworks.

Changes based on #3964.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@jjlharrison jjlharrison marked this pull request as ready for review June 7, 2022 10:02
@adangel adangel added this to the 6.47.0 milestone Jun 7, 2022

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! 👍

@ghost

ghost commented Jun 7, 2022

Copy link
Copy Markdown
1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 34 violations, 2 errors and 6 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel merged commit f5e3ab9 into pmd:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] ImmutableField reports fields annotated with @Captor (Mockito) [java] ImmutableField reports fields annotated with @Value (Spring)

2 participants