Skip to content

[core] Fix #3768 SARIF: report each violation as separate result#3788

Merged
adangel merged 2 commits intopmd:masterfrom
adangel:issue-3768-sarif-multiple-locations
Feb 25, 2022
Merged

[core] Fix #3768 SARIF: report each violation as separate result#3788
adangel merged 2 commits intopmd:masterfrom
adangel:issue-3768-sarif-multiple-locations

Conversation

@adangel
Copy link
Copy Markdown
Member

@adangel adangel commented Feb 17, 2022

Now one violation is mapped to exactly one result.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

... when it should report multiple results instead.
Now one violation is mapped to exactly one result.

Fixes pmd#3768
@adangel adangel added this to the 6.43.0 milestone Feb 17, 2022
@ghost
Copy link
Copy Markdown

ghost commented Feb 17, 2022

1 Message
📖 This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel changed the title [core] Fix #3768 report each violation as separate result [core] Fix #3768 SARIF report each violation as separate result Feb 19, 2022
@adangel adangel changed the title [core] Fix #3768 SARIF report each violation as separate result [core] Fix #3768 SARIF: report each violation as separate result Feb 19, 2022
@adangel adangel merged commit 9a437b0 into pmd:master Feb 25, 2022
@adangel adangel deleted the issue-3768-sarif-multiple-locations branch February 25, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] SARIF formatter reports multiple locations when it should report multiple results

1 participant