[java] Update rule SignatureDeclareThrowsException#3731
Merged
oowekyala merged 2 commits intoJan 26, 2022
Merged
Conversation
Generated by 🚫 Danger |
oowekyala
reviewed
Jan 15, 2022
oowekyala
approved these changes
Jan 26, 2022
oowekyala
left a comment
Member
There was a problem hiding this comment.
AFAICT, there are FPs due to overridden methods that don't have an @Override annotation. We're anyway using ASTMethodDeclaration::isOverridden, which I'd like to improve to do the same thing as MissingOverride in a resolution pass after parsing. This will suppress FPs in more rules, and we don't need to fix it in this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2701