[java] Update rule AvoidDuplicateLiterals#3663
Conversation
Generated by 🚫 Danger |
|
There is one fishy positive: https://github.com/checkstyle/checkstyle/blob/cfd1c333a866bd32912a1947e86ac0fceaf3ad65/src/test/resources/com/puppycrawl/tools/checkstyle/checks/suppresswarningsholder/InputSuppressWarningsHolder5.java#L11-L13 Maybe we should allow dups in annotations? |
It turns out, we have already a property to do this: "skipAnnotations". It is by default off, so by default the rule will report duplicated string literals in annotations. The question remains however: Would it make sense to switch the default of this property? I don't see any report for this case, so I would argue, we just keep it as-is. |
Part of #2701