[java] Update rule MethodWithSameNameAsEnclosingClass#3651
Merged
adangel merged 2 commits intoJan 11, 2022
Merged
Conversation
Converted the rule into a simle XPath rule
Generated by 🚫 Danger |
oowekyala
approved these changes
Dec 31, 2021
Member
|
The rule also should consider other kinds of classes like enums and records. Maybe this PR is a good place to do this |
Member
Author
No, this should be a different PR to keep the update to pmd7 focused. I've created #3723 for this improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted the rule into a simle XPath rule
Part of #2701