You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 2230 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors. Full report
📖
Compared to master:
This changeset changes 45981 violations,
introduces 25578 new violations, 5 new errors and 0 new configuration errors,
removes 179969 violations, 27 errors and 3 configuration errors. Full report
✅
Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 2229 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors. Full report
✅
Compared to master:
This changeset changes 45981 violations,
introduces 25578 new violations, 5 new errors and 0 new configuration errors,
removes 179970 violations, 27 errors and 3 configuration errors. Full report
✅
Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 2163 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors. Full report
✅
Compared to master:
This changeset changes 45900 violations,
introduces 25761 new violations, 38 new errors and 0 new configuration errors,
removes 180011 violations, 28 errors and 3 configuration errors. Full report
I think I'll merge this.. In the long term I think this rule should be deprecated though. Its justification is really bad:
Sometimes, this type of assignment is an indication that the programmer doesn't completely understand what is going on in the code.
This is completely unverifiable. The message is even worse:
Assigning an Object to null is a code smell. Consider refactoring.
null is not more dangerous when assigned into a variable than in other places, so the rule really has no reason to exist.
Using data flow analysis we should try to detect possible NPEs in a useful manner, not just blindly flag all null literals in the program. I think this kind of very noisy and badly justified rules make PMD look bad and they should be hunted down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2701