Skip to content

[java] Update rule AvoidBranchingStatementAsLastInLoop#3592

Merged
adangel merged 2 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-AvoidBranchingStatementAsLastInLoop
Nov 12, 2021
Merged

[java] Update rule AvoidBranchingStatementAsLastInLoop#3592
adangel merged 2 commits into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-AvoidBranchingStatementAsLastInLoop

Conversation

@adangel

@adangel adangel commented Oct 28, 2021

Copy link
Copy Markdown
Member

Part of #2701

@adangel adangel added this to the 7.0.0 milestone Oct 28, 2021
@ghost

ghost commented Oct 28, 2021

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 155 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 31211 violations,
introduces 21296 new violations, 1 new errors and 0 new configuration errors,
removes 135495 violations, 8 errors and 3 configuration errors.
Full report
Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 199 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
Compared to master:
This changeset changes 31211 violations,
introduces 21377 new violations, 1 new errors and 0 new configuration errors,
removes 135621 violations, 8 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@adangel

This comment has been minimized.

positives

Foreach loops are now a separate AST node.
If the loop statements don't use curly braces and have no Block
then we need to use the direct parent instead of grandparent
to check for the loops.
@adangel

adangel commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

The false positives / negatives are fixed now. I'm going to merge this.

@adangel adangel self-assigned this Nov 11, 2021
@adangel adangel merged commit 6e9343d into pmd:pmd/7.0.x Nov 12, 2021
@adangel adangel deleted the pmd7-update-AvoidBranchingStatementAsLastInLoop branch November 12, 2021 08:10
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant