Skip to content

[java] Update rule SingleMethodSingleton#3531

Merged
oowekyala merged 1 commit into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-SingleMethodSingleton
Oct 25, 2021
Merged

[java] Update rule SingleMethodSingleton#3531
oowekyala merged 1 commit into
pmd:pmd/7.0.xfrom
adangel:pmd7-update-SingleMethodSingleton

Conversation

@adangel

@adangel adangel commented Sep 30, 2021

Copy link
Copy Markdown
Member

Describe the PR

Part of #2701

Important general change: Any nested type is now a find boundary.

Any nested type is now a find boundary.
@adangel adangel added this to the 7.0.0 milestone Sep 30, 2021
@ghost

ghost commented Sep 30, 2021

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 47 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 31204 violations,
introduces 21205 new violations, 1 new errors and 0 new configuration errors,
removes 137186 violations, 8 errors and 3 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala

oowekyala commented Oct 25, 2021

Copy link
Copy Markdown
Member

Important general change: Any nested type is now a find boundary.

I think this makes sense... Though having find boundaries in the tree is unintuitive and maybe the default behavior of descendants should be to cross find boundaries. I used to think we could remove that concept altogether in pmd 7, not sure if we can still do that...

@oowekyala oowekyala self-assigned this Oct 25, 2021
@oowekyala oowekyala merged commit 7c11faa into pmd:pmd/7.0.x Oct 25, 2021
@adangel adangel deleted the pmd7-update-SingleMethodSingleton branch October 28, 2021 13:24
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants