Generated by 🚫 Danger

There seem to a lot of false negatives now:

// https://github.com/spring-projects/spring-framework/tree/v5.0.6.RELEASE/spring-context/src/test/java/org/springframework/beans/factory/xml/XmlBeanFactoryTests.java#L917
assertTrue(!rod6.destroyed);
// https://github.com/spring-projects/spring-framework/tree/v5.0.6.RELEASE/spring-tx/src/test/java/org/springframework/transaction/TransactionSupportTests.java#L89
assertTrue("no rollback", !tm.rollback);

is missing now...

Maybe that's a real fix? According to the rule description only boolean literals should be detected: https://pmd.github.io/pmd/pmd_rules_java_errorprone.html#unnecessarybooleanassertion

There are two interesting test cases on pmd6:

But I guess, this is a little bit different: Instead of assertTrue(!something) one should write assertFalse(something)... Not sure, if this really is in the realm of this rule - as it is clearly not assertTrue(true) and so it is not unnecessary (except "something" would be a boolean constant)....

Ok, see #3087 - this is actually UnneccessaryBooleanAssertion doing the same as SimplifiableTestAssertion (formerly SimplifyBooleanAssertion). So, we should probably really remove this from this rule.