Generated by 🚫 Danger

Maybe the following is a false-positive, wdyt?

parsedDate = calb.establish(calendar).getTime();

(https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/text/SimpleDateFormat.java#L1559)

calb is a CalendarBuilder, calb.establish() returns a java.util.Calendar on which getTime() is called. But we should probably only report this, if the calendar instance is created here....

return new Date(getTimeInMillis());

(https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/util/Calendar.java#L1785)

We should not report this. It calls getTimeInMillis() on "this" (which happens to be here java.util.Calendar...).

c = new Calendar.Builder().setTimeZone(TimeZone.getTimeZone("GMT"))
                    .setDate(year, month - 1, day).build();
...
denyAfterDate = c.getTime();

(https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java#L636)

That's also a false-positive: The calendar "c" is not created via getInstance, but via a builder with a specific date set....

Date sentDate = new GregorianCalendar(2004, 1, 1).getTime();

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-context-support/src/test/java/org/springframework/mail/javamail/JavaMailSenderTests.java#L73)

This creates a new calendar instance with a specific date set via constructor... That's also a false-positive

Update: All of these have been fixed ✔️