Generated by 🚫 Danger

1. false-negative:

WRONG_LANGUAGE_CODE_KEY, new Object[] {code}, getId(), getClass(), null);

(https://github.com/checkstyle/checkstyle/blob/checkstyle-8.10/src/main/java/com/puppycrawl/tools/checkstyle/checks/TranslationCheck.java#L209)

ArrayAllocations are not considered anymore obviously....

2. fixed false-positive:

for (String configName : new String[] {"config", "test"}) {

(https://github.com/checkstyle/checkstyle/blob/checkstyle-8.10/src/test/java/com/puppycrawl/tools/checkstyle/internal/XdocsPagesTest.java#L1386)

We should add a test case for this.

3. fixed false-positive:

this.propertyValueList.add(new PropertyValue(pv));

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-beans/src/main/java/org/springframework/beans/MutablePropertyValues.java#L73)

Maybe worth to add a test case - I guess in pmd6 we stumble over "this." ...

4. fixed false-positive:

this.configResources[i] = new ClassPathResource(paths[i], clazz);

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-context/src/main/java/org/springframework/context/support/ClassPathXmlApplicationContext.java#L200)

Same as 3 - we probably stumble in pmd6 over "this." for this array access. Maybe worth a test case.

5. accidentally fixed false-positive:

dataBuffers.add(this.bufferFactory.wrap(new byte[]{b}));

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-core/src/test/java/org/springframework/core/codec/StringDecoderTests.java#L87)

I think, this is not reported because of the array allocation. But we should make sure, that this is not reported at all, because it is part of the "Collection.add" call - which should be ignored. In this case, it is not the direct argument, but only indirectly.

6. false-positive:

cookieStrings[i] = new ToStringCreator(cookie)...

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-test/src/main/java/org/springframework/test/web/servlet/result/PrintingResultHandler.java#L271)

It's assigning it to an array so it should be ignored. Maybe we don't recognize the method call chain correctly...

Update: All of these have been fixed ✔️

New round:

1. false positive

powerCache[i] = new BigInteger[] { BigInteger.valueOf(i) };

(https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/java/math/BigInteger.java#L1255)

ArrayAllocation should also be ignored if it is assigned to an array (like collection).

2. false positive

return new Proxy[] {SocksProxy.create(saddr, socksProxyVersion())};

(https://github.com/openjdk/jdk/blob/jdk-11%2B28/src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java#L316)

ArrayAllocation should also be ignored, if the array is returned and therefore the loop is exited.

3. fixed false positive - need to add a test

pathResolver.setAllowedLocations(getLocations().toArray(new Resource[0]));

(https://github.com/spring-projects/spring-framework/blob/v5.0.6.RELEASE/spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java#L390)

getLocations() returns a Collection, so the ArrayAllocation is used in a collection method call. That's correct, this usage should not be flagged.

Update: All of these have been fixed ✔️