[core] Extend the Report class to store custom data objects#3357
Closed
aaronhurst-google wants to merge 1 commit into
Closed
[core] Extend the Report class to store custom data objects#3357aaronhurst-google wants to merge 1 commit into
aaronhurst-google wants to merge 1 commit into
Conversation
…are indexed by runtime object type. Change-Id: I143de1a332a1fbab562e33946daf041d1f32c0a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the Report class to store custom MergeableData objects, one per runtime type.
Describe the PR
Our org is building some custom PMD rules that require gathering and then post-processing global data. This pull request supports with the former aspect. I think it would be very useful to others.
The MergeableData defines the minimum interface of the stored data, which needs to be merged as the containing Report objects are merged. Our custom Rules add these to the Report (e.g. as method summaries, conditional violations.) They are later consumed by a Renderer, in order to output additional custom information. For example, one of our use cases is to extract properties about test code.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)