[java] Update ExcessiveSomething rules#3308
Conversation
ExcessiveClassLengthRule ExcessiveImportsRule ExcessiveMethodLengthRule ExcessiveParameterListRule ExcessivePublicCountRule
Generated by 🚫 Danger |
|
It looks like only ExcessiveImports and ExcessiveParameterList report violations, the other rules (ExcessivePublicCount, ExcessiveMethodLength and ExcessiveClassLength) are missing.... although they should have been executed (https://chunk.io/pmd/21f16d5b72d84252a6c7558239e43f75/diff2/patch_config.xml), they look like, they are just skipped.... I'll have a look at this. |
|
Maybe it's really because there were literally now changes for these rules. The regression tester for pmd7 really didn't execute these: https://chunk.io/pmd/21f16d5b72d84252a6c7558239e43f75/diff1/patch_config.xml But for the comparison with master, they should have been there... but I see false-negatives now. Actually, there are only removed violations. Maybe we filter really only to the two rules that have changes? |
|
Ok, so we first execute pmd-regression-tester against pmd/7.0.x. There we figured out (from git diff), that only the rules ExcessiveImports and ExcessiveParameterList have been changed and run PMD with a ruleset only with these two rules enabled. |
The regression tester executes only rules, that actually have been changed.
Describe the PR
Update rules
most of them without changes.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)