[javascript] Update Rhino library to 1.7.13#3242
Merged
Merged
Conversation
This was referenced Apr 29, 2021
Generated by 🚫 Danger |
oowekyala
approved these changes
May 14, 2021
oowekyala
left a comment
Member
There was a problem hiding this comment.
Thanks! I'll keep this pr as a reference of what to update when a module changes minimum java version.
Co-authored-by: Clément Fournier <clement.fournier76@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the older #2906
Note: This introduces some incompatibility: From now on, at least Java 8 is required to analyze JavaScript code.
We did a similar upgrade with VisualForce in 6.30.0.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)