[core] Make more rules be recognized as rulechain (saxon HE)#3207
Merged
Conversation
Now we have a normalization step that pulls up filters, and reduces the start expression, so that the rulechain analyser can recognise the pattern Add tests for java rulechain Rules that were not recognized as Rulechain and that now are: - AvoidDecimalLiteralsInBigDecimalConstructor - AvoidPrintStackTrace - AvoidSynchronizedAtMethodLevel - AvoidUsingVolatile - DoNotUseThreads - DontCallThreadRun - EmptyMethodInAbstractClassShouldBeAbstract - JUnit4TestShouldUseTestAnnotation - LocalHomeNamingConvention - LocalInterfaceSessionNamingConvention - MDBAndSessionBeanNamingConvention - RemoteInterfaceNamingConvention - RemoteSessionInterfaceNamingConvention - ReplaceHashtableWithMap - ReplaceVectorWithList - SimplifyStartsWith - StringToString - UseAssertEqualsInsteadOfAssertTrue - UseAssertNullInsteadOfAssertTrue - UseAssertSameInsteadOfAssertTrue - UseAssertTrueInsteadOfAssertEquals - UseStringBufferLength
oowekyala
commented
Apr 9, 2021
ca2e632 to
e2a4857
Compare
Generated by 🚫 Danger |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
I noticed many java XPath rules were not recognized as rulechain ones and investigated. Saxon parses some expressions somewhat inconsistently. Now we have a normalization step that should bring more rules in line with what the RuleChainAnalyser expects.
Java rules that were not recognized as Rulechain and that now are:
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)