[java] Update rule LooseCoupling#3177
Merged
Merged
Conversation
d746393 to
1a3fea8
Compare
Generated by 🚫 Danger |
This is because I saw a lot of them being things like ImmutableList, which are project-specific
adangel
reviewed
Apr 1, 2021
adangel
left a comment
Member
There was a problem hiding this comment.
Thanks.
Can you look at the following two cases? I think, these are false positives and should not be reported:
-
"Avoid using implementation types like 'AbstractMap'; use the interface instead"
-
"Avoid using implementation types like 'InputRegressionJavaClass2'; use the interface instead"
This was
linked to
issues
Apr 2, 2021
adangel
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)