[java] CloseResource: false positive with reassignment detection#3147
Merged
adangel merged 3 commits intoMar 27, 2021
Conversation
Generated by 🚫 Danger |
oowekyala
reviewed
Mar 27, 2021
| // The sibling before the operator is the left hand side | ||
| JavaNode lhs = assignment.getParent().getChild(assignment.getIndexInParent() - 1); | ||
|
|
||
| ASTName name = lhs.getFirstDescendantOfType(ASTName.class); |
Member
There was a problem hiding this comment.
Not sure if this is important, but this descendants check could misinterpret array[...] = ..., because it will fetch the name of the array.
Might be worth figuring out a test case
Member
Author
There was a problem hiding this comment.
I've tested it a bit and I don't think, that's relevant: If the variable we search here would actually be an array, we wouldn't search it in the first place, because then it is not autocloseable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready?
./mvnw clean verifypasses (checked automatically by travis)