Skip to content

[all] Call jjtree/javacc with UTF-8 as default encoding#2981

Merged
adangel merged 3 commits into
pmd:masterfrom
adangel:reproducible-jjtree
Jan 16, 2021
Merged

[all] Call jjtree/javacc with UTF-8 as default encoding#2981
adangel merged 3 commits into
pmd:masterfrom
adangel:reproducible-jjtree

Conversation

@adangel

@adangel adangel commented Dec 17, 2020

Copy link
Copy Markdown
Member

Describe the PR

  • Calls jjtree/javacc in a forked vm, so that we can explicitly set the default platform encoding
  • Explicitly sets the default platform encoding to UTF-8

Note: This won't merge into pmd/7.0.x. There the corresponding change needs to be done in /javacc-wrapper.xml.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 6.31.0 milestone Dec 17, 2020
@adangel adangel self-assigned this Jan 15, 2021
@ghost

ghost commented Jan 15, 2021

Copy link
Copy Markdown
1 Message
📖 This changeset changes violations,
introduces new violations, new errors and new configuration errors,
removes violations, errors and configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel merged commit 2591234 into pmd:master Jan 16, 2021
@adangel adangel deleted the reproducible-jjtree branch January 17, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[core] PMD 6.30.0 release is not reproducible

1 participant