Skip to content

[core] Deprecate old traversal methods on the Node interface#2886

Merged
oowekyala merged 9 commits into
pmd:pmd/7.0.xfrom
oowekyala:deprecate-find-xx-of-any-type
Dec 10, 2020
Merged

[core] Deprecate old traversal methods on the Node interface#2886
oowekyala merged 9 commits into
pmd:pmd/7.0.xfrom
oowekyala:deprecate-find-xx-of-any-type

Conversation

@oowekyala

@oowekyala oowekyala commented Oct 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Most of them can be replaced by node streams, which is more efficient especially for descendant streams. I think it's important to do this before updating java rules, so that we don't forget to use the newer APIs. Refs #1622, #2701

Fixes #2218

Ready?

  • Release notes
  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala
Deprecate old traversal methods
f8e5c24 
Most of them can be replaced by node streams,
which is more efficient especially for descendant streams

Give an optimal implementation of firstChild for
array-based nodes

Also deprecate getImage

Make isFindBoundary a NoAttribute
@oowekyala oowekyala added this to the 7.0.0 milestone Oct 30, 2020
@ghost

ghost commented Oct 30, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
2 Messages
📖 Compared to pmd/7.0.x:
This changeset changes 0 violations,
introduces 0 new violations, 1 new errors and 0 new configuration errors,
removes 0 violations, 1 errors and 0 configuration errors.
Full report
📖 Compared to master:
This changeset changes 695 violations,
introduces 1265 new violations, 10 new errors and 0 new configuration errors,
removes 1059 violations, 16 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset introduces 0 new violations, 1 new errors and 0 new configuration errors,
removes 0 violations, 1 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset introduces 929 new violations, 11 new errors and 0 new configuration errors,
removes 220 violations, 16 errors and 2 configuration errors.
Full report
✅ Compared to pmd/7.0.x:
This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 138 violations, 1 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset introduces 178 new violations, 6 new errors and 0 new configuration errors,
removes 136 violations, 16 errors and 2 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala mentioned this pull request Nov 11, 2020
Closed
2 tasks
@oowekyala oowekyala linked an issue Nov 11, 2020 that may be closed by this pull request
[core] isFindBoundary should not be an attribute #2218
Closed
2 tasks
@oowekyala oowekyala marked this pull request as ready for review November 13, 2020 10:01
@oowekyala oowekyala self-assigned this Dec 10, 2020
@oowekyala oowekyala merged commit 7d102cb into pmd:pmd/7.0.x Dec 10, 2020
@oowekyala oowekyala deleted the deprecate-find-xx-of-any-type branch December 10, 2020 19:48
@adangel adangel added the in:ast About the AST structure or API, the parsing step label Jan 12, 2023
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oowekyala oowekyala

Labels

in:ast About the AST structure or API, the parsing step

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[core] isFindBoundary should not be an attribute

2 participants

@oowekyala @adangel