Skip to content

[core] Test some XPath corner cases#2872

Merged
oowekyala merged 6 commits into
pmd:masterfrom
oowekyala:xpath-doc-nodes
Oct 28, 2020
Merged

[core] Test some XPath corner cases#2872
oowekyala merged 6 commits into
pmd:masterfrom
oowekyala:xpath-doc-nodes

Conversation

@oowekyala

@oowekyala oowekyala commented Oct 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Describe the PR

These are fixed only for Saxon. The merge into 7.0.x will be non-trivial though.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added the in:xpath Relating to xpath support at large, eg Jaxen / Saxon, custom functions, attribute resolution label Oct 26, 2020
@oowekyala oowekyala added this to the 6.30.0 milestone Oct 26, 2020
@oowekyala oowekyala changed the title [core] Test some parts of XPath [core] Test some XPath corner cases Oct 26, 2020
@ghost

ghost commented Oct 26, 2020

Copy link
Copy Markdown
1 Message
📖 This changeset introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@oowekyala oowekyala linked an issue Oct 27, 2020 that may be closed by this pull request
[core] Jaxen adapter implements document nodes incorrectly #1938
Closed
@oowekyala oowekyala marked this pull request as ready for review October 27, 2020 00:26
adangel
adangel approved these changes Oct 28, 2020
View reviewed changes
Comment thread docs/pages/release_notes.md Outdated
Comment thread docs/pages/release_notes.md Outdated
@adangel adangel self-assigned this Oct 28, 2020
@oowekyala oowekyala assigned oowekyala and unassigned adangel Oct 28, 2020
@oowekyala @adangel
Fix release notes format
3e23e66 
Co-authored-by: Andreas Dangel <andreas.dangel@pmd-code.org>
@oowekyala oowekyala merged commit ec89913 into pmd:master Oct 28, 2020
@oowekyala oowekyala deleted the xpath-doc-nodes branch October 28, 2020 22:05
This was referenced Oct 30, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

@oowekyala oowekyala

Labels

in:xpath Relating to xpath support at large, eg Jaxen / Saxon, custom functions, attribute resolution

Projects

None yet

Milestone

6.30.0

Development

Successfully merging this pull request may close these issues.

[core] XPath expressions return handling [core] Jaxen adapter implements document nodes incorrectly

2 participants

@oowekyala @adangel