Skip to content

[java] Update UnusedAssignmentRule to PMD 7 grammar#2794

Merged
adangel merged 5 commits into
pmd:pmd/7.0.xfrom
oowekyala:reimplement-unused-assignment
Sep 24, 2020
Merged

[java] Update UnusedAssignmentRule to PMD 7 grammar#2794
adangel merged 5 commits into
pmd:pmd/7.0.xfrom
oowekyala:reimplement-unused-assignment

Conversation

@oowekyala

@oowekyala oowekyala commented Sep 18, 2020

Copy link
Copy Markdown
Member

Describe the PR

  • Update UnusedAssignment
  • As described on [java] Java-grammar progress document #2701 I think the reaching definitions analysis may be useful for other rules, and maybe for the symbol table. This is work for later, but reenabling the tests of the rule is good for future refactorings.

This also fixes a bug with call chains. I'll open an issue to describe it (-> #2796)

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by travis)
  • Added (in-code) documentation (if needed)

@oowekyala oowekyala added this to the 7.0.0 milestone Sep 18, 2020
@ghost

ghost commented Sep 18, 2020

Copy link
Copy Markdown
1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

@adangel adangel self-assigned this Sep 24, 2020
@adangel adangel merged commit 70f1aec into pmd:pmd/7.0.x Sep 24, 2020
@oowekyala oowekyala deleted the reimplement-unused-assignment branch September 24, 2020 11:33
@adangel adangel mentioned this pull request Jan 23, 2023
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java] UnusedAssignment false positive with call chains

2 participants