[java] Implement constant values#2777
Merged
Merged
Conversation
Generated by 🚫 Danger |
adangel
approved these changes
Sep 17, 2020
| if (constVal instanceof String) { | ||
| String stringVal = (String) constVal; | ||
| if ("PMD".equals(stringVal) | ||
| || ("PMD." + rule.getName()).equals(stringVal) // NOPMD uselessparentheses false positive |
Member
There was a problem hiding this comment.
("PMD." + rule.getName()).equals(stringVal)// NOPMD uselessparentheses false positive
Seems to be #2739
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Finish implementing ASTExpression#getConstValue, by also considering things like references to constant fields, and eg constant string concatenations, additions, etc.
Related issues
@SuppressWarningswith constants instead of literals #520: now, we can use constant expressions to suppress warningsReady?
./mvnw clean verifypasses (checked automatically by travis)