[core, ...] Finish generic visitors#2746
Merged
Merged
Conversation
Generated by 🚫 Danger |
10 tasks
adangel
approved these changes
Sep 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Finish implementing #880, ie the following items:
Language modules to port:
Cleanup after this:
[ ] Remove default implementation in Node-> I think it's useful to have a default as some languages do not support visitors (eg we have XML)In future work (probably as part of rewriting rules), some visitor implementations could be generified. Eg many metrics visitors.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by travis)