[java] New Performance Rule AvoidCalendarDateCreation#2576
Merged
Conversation
Including unit tests and examples. Originating from github.com/jborgers/PMD-jPinpoint-rules. Links to more doc later.
Generated by 🚫 Danger |
Member
Author
|
I think, this one is ready now. It still has a few false-positives (e.g. if the calendar is a field, it's also not created locally or if it is passed in and cast to Calendar). But I'd suggest to add this rule and see how the feedback is. |
oowekyala
approved these changes
Jun 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
This is the rule "AvoidCalendarDateCreation" split from original PR #1932 .
Related issues
Ready?
https://github.com/spring-projects/spring-framework/tree/v5.0.6.RELEASE/spring-context/src/main/java/org/springframework/format/datetime/DateFormatterRegistrar.java#L112
./mvnw clean verifypasses (checked automatically by travis)