Skip to content

[javascript] Use new javacc wrapper in JS module#2362

Merged
adangel merged 1 commit into
pmd:pmd/7.0.xfrom
oowekyala:port-js-module
Mar 19, 2020
Merged

[javascript] Use new javacc wrapper in JS module#2362
adangel merged 1 commit into
pmd:pmd/7.0.xfrom
oowekyala:port-js-module

Conversation

@oowekyala

@oowekyala oowekyala commented Mar 17, 2020

Copy link
Copy Markdown
Member

Refs #2239

@oowekyala oowekyala added this to the 7.0.0 milestone Mar 17, 2020
@oowekyala oowekyala mentioned this pull request Mar 17, 2020
Closed
22 tasks
@ghost

ghost commented Mar 17, 2020

Copy link
Copy Markdown
1 Message
📖 No java rules are changed!

Generated by 🚫 Danger

adangel
adangel approved these changes Mar 19, 2020
View reviewed changes
Comment thread ...vascript/src/main/java/net/sourceforge/pmd/lang/ecmascript5/ast/Ecmascript5TokenManager.java
/**
* Ecmascript 5 Token Manager implementation.
*
* @deprecated This is internal API

@adangel adangel Mar 19, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove this javadoc and keep @InternalApi when merging

@adangel adangel merged commit e23df57 into pmd:pmd/7.0.x Mar 19, 2020
@oowekyala oowekyala deleted the port-js-module branch March 19, 2020 15:48
@adangel adangel changed the title [js] Use new javacc wrapper in JS module [javascript] Use new javacc wrapper in JS module Jan 13, 2023
@adangel adangel mentioned this pull request Jan 23, 2023
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@oowekyala @adangel