Skip to content

[java] Add support for java 14#2318

Merged
oowekyala merged 34 commits into
pmd:masterfrom
adangel:java14
Mar 2, 2020
Merged

[java] Add support for java 14#2318
oowekyala merged 34 commits into
pmd:masterfrom
adangel:java14

Conversation

@adangel

@adangel adangel commented Feb 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • Java 14 is the new default version for java
  • There is a new java 14 preview version
  • Switch Expressions are supported in java 14
  • ASM is updated
  • Text Block for java 14 preview
  • Pattern matching for instance of
  • Records
  • Remove java 12 preview and break-with-return
  • Release notes

Fixes #2159

Limitations:

  • Variables that are bound to a pattern, are not available in the symbol table
  • The symbol table knows nothing about the fields of a record type

oowekyala and others added 12 commits February 8, 2020 20:22
@oowekyala
Add java version 14
6e4daad
@oowekyala
Support type test patterns
ad023e8
@oowekyala
Make sure symbol table doesn't cry on duplicate name
5a6d332
@oowekyala
Mark new API as experimental
97a4394
@adangel
Merge remote-tracking branch 'oowekyala/jdk14-pattern-matching' into …
3a28355 
…jdk14
@adangel
[java] version 14 is now the new default
f3da339
@adangel
[java] Make sure, SwitchExpressions with yield work with java14
9d5b755 
Add additional tests for java14, so that we can later simply remove
the java13 preview tests
@adangel
[java] Add support for TextBlocks in Java14
d16751d 
* New escape sequence "\s" added
* Added experimental ASTLiteral::getTextBlockContent to retrieve
  the text block with stripped indentation
@adangel
Fix checkstyle
da01ed4
@adangel
[java] Don't throw IllegalArgument if Literal is not a text block
81bb809
@adangel
[java] Fix new escape sequence "\s" detection
9a80f13
@adangel
Update asm to 7.3.1
01db024 
This add support for java 14 and java 15
@ghost

ghost commented Feb 27, 2020 •
edited by ghost
Loading

Copy link
Copy Markdown
1 Warning
⚠️ This PR cannot be merged yet.
✅ Well done.
✅ This changeset introduces 0 new violations, 16 new errors and 0 new configuration errors,
removes 0 violations, 16 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 16 new errors and 0 new configuration errors,
removes 0 violations, 16 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 16 new errors and 0 new configuration errors,
removes 0 violations, 16 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 16 new errors and 0 new configuration errors,
removes 0 violations, 16 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 15 new errors and 0 new configuration errors,
removes 0 violations, 15 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 15 new errors and 0 new configuration errors,
removes 0 violations, 15 errors and 0 configuration errors.
Full report
✅ This changeset introduces 0 new violations, 15 new errors and 0 new configuration errors,
removes 0 violations, 15 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

oowekyala
oowekyala reviewed Feb 27, 2020
View reviewed changes
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTLiteral.java Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTLiteral.java Outdated
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTLiteral.java Outdated
adangel added 16 commits February 28, 2020 09:43
@adangel
[java] ASTLiteral - move the tests for text block content
8a90c2d 
Also fix determining the start of the content, when there are
multiple line terminators without indenting whitespace.
@adangel
[java] Don't consider VariableDeclaratorIds of Pattern Bindings for now
09ff74e
@adangel
[java] VariableDeclarationId of pattern bindings is implicitly final
b1acb29
@adangel
[java] Update grammar
adfb2ab
@adangel
[java] Rewrite escape sequence interpreting for text blocks
524925f
@adangel
[java] Add initial support for Java 14 Preview record types
8a22446
@adangel
[java] Add grammar jdoc for new Record types
e2d84d6
@adangel
[java] RecordComponents -> RecordComponentList
9917e3f
@adangel
[java] RecordConstructorDeclaration - do not use Name()
5f43e19
@adangel
[java] Support vararg/array in RecordComponent and empty components
e017def
@adangel
[java] Test nested record type
68ba8a9
@adangel
[java] Test annotations with RecordComponents
fa28aa7
@adangel
[java] Get rid of RecordBodyDeclaration node
0ecd1da
@adangel
[java] RecordBody - test with more annotation and use deep lookahead
7d3df99 
Record constructors are not allowed to throw exceptions.
@adangel
[java] Support RecordConstructorDeclaration as AnyTypeBodyDeclaration
2ace55f
@adangel
[java] Remove unneccessary annotation parsing
ee211d4
@adangel adangel marked this pull request as ready for review February 28, 2020 18:51
@adangel adangel added this to the 6.22.0 milestone Feb 28, 2020
adangel
adangel commented Feb 29, 2020
View reviewed changes
Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTRecordBody.java Outdated
@adangel adangel added the in:ast About the AST structure or API, the parsing step label Feb 29, 2020
oowekyala
oowekyala approved these changes Mar 2, 2020
View reviewed changes

@oowekyala oowekyala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready, thanks for your work on this! Merging this onto java-grammar will probably not be easy. I think, it should be done before merging #2300

Comment thread pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/ASTLiteral.java
oowekyala
oowekyala reviewed Mar 2, 2020
View reviewed changes
Comment thread pmd-java/etc/grammar/Java.jjt
@oowekyala oowekyala merged commit fc0b437 into pmd:master Mar 2, 2020
@adangel adangel deleted the java14 branch March 2, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oowekyala oowekyala oowekyala approved these changes

Assignees

No one assigned

Labels

in:ast About the AST structure or API, the parsing step

Projects

None yet

Milestone

6.22.0

Development

Successfully merging this pull request may close these issues.

[java] Prepare for JDK 14

2 participants

@adangel @oowekyala