Skip to content

[java] Qualify references to inner classes of imports#225

Merged
adangel merged 1 commit into
pmd:masterfrom
jsotuyod:qualify-inner-class-of-import
Feb 12, 2017
Merged

[java] Qualify references to inner classes of imports#225
adangel merged 1 commit into
pmd:masterfrom
jsotuyod:qualify-inner-class-of-import

Conversation

@jsotuyod

Copy link
Copy Markdown
Member
  • Given an import on a.Foo, references to Foo.Inner should be qualified
    as a.Foo.Inner.
  • This fixes a couple of wrong missing classes.
  • The test also brought to light another issue with resolvers that would fail
    to resolve even a qualified inner class if not explicitly imported under
    certain circumstances.

 - Given an import on `a.Foo`, references to `Foo.Inner` should be qualified
    as `a.Foo.Inner`.
 - This fixes a couple of wrong missing classes.
 - The test also brought to light another issue with resolvers that would fail
    to resolve even a qualified inner class if not explicitly imported under
    certain circumstances.
@jsotuyod jsotuyod added the a:bug PMD crashes or fails to analyse a file. label Jan 31, 2017
@jsotuyod jsotuyod added this to the 5.5.4 milestone Jan 31, 2017
@jsotuyod jsotuyod mentioned this pull request Jan 31, 2017
5 tasks
@adangel

adangel commented Feb 12, 2017

Copy link
Copy Markdown
Member

Thanks! It's merged into pmd/5.5.x and master branches.

@adangel adangel merged commit 8f8d4be into pmd:master Feb 12, 2017
@jsotuyod jsotuyod deleted the qualify-inner-class-of-import branch February 12, 2017 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:bug PMD crashes or fails to analyse a file.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants