[core] Remove statistical rule (final step)#2005
Merged
Merged
Conversation
Residues of the rebase
Member
|
@oowekyala there seems to be some checkstyle issues failing the build: |
Generated by 🚫 Danger |
jsotuyod
approved these changes
Sep 24, 2019
jsotuyod
left a comment
Member
There was a problem hiding this comment.
Rerun Travis and it passed this time 🤷♂
13 tasks
This was referenced Jan 10, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ports the few StatisticalRules that remain in the PLSQL and VTL modules to regular rules (using the same design as #1750 and #1772).
It also removes StatisticalRule and co from the codebase.
TODO on master: deprecate the methods
Report::hasMetrics,Report::metrics