[java] Simplify array allocation expressions#1981
Merged
Merged
Conversation
This simplifies the grammar of allocation expressions, they now have an array type as a child
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor simplification of the grammar of array allocation expressions.
I'm not sure we really need an ArrayDimExpr node, ArrayTypeDim could as well have an optional child for the expression, but I'm concerned the API of that node would be more complex.
This prepares for fixing #997. We now have a single node type for array dimensions. We can add it in VariableDeclaratorId and MethodDeclaration, and get rid of Dimensionable. This fix has to wait for #1980 because both touch the VariableDeclaratorId production