[java] Hide internal AST api#1856
Merged
adangel merged 13 commits intoJun 17, 2019
Merged
Conversation
adangel
approved these changes
Jun 17, 2019
adangel
left a comment
Member
There was a problem hiding this comment.
Good idea with InternalApiBridge - that keeps these methods separated and we ca revisit them later (e.g. ideally rule implementations wouldn't need this - if they call a method from the bridge, they obviously do too much, like the comment rules...).
| return isModifier(PROTECTED); | ||
| } | ||
|
|
||
| void setProtected(boolean isProtected) { |
Member
There was a problem hiding this comment.
Strange, this is already deprecated/internal on master, but not here.... We'll probably get conflicts here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As you said @adangel I think it's useful to do that early on, because that allows us to work on a package that's not vastly deprecated.
The remaining public setters on nodes are those from Node and AbstractNode, which we should probably deprecate on master and make protected later on.