[java] Fix annotated module declaration#1843
Merged
Merged
Conversation
Generated by 🚫 Danger |
adangel
approved these changes
May 25, 2019
adangel
left a comment
Member
There was a problem hiding this comment.
Indeed this ( < "~[]" > )? is really weird. Also the line above ( < "\u001a" > )? looks unnecessary.
We might simply remove these two lines (in PMD 7). I think, we could make sure, that we don't fail to parse an empty file (containing only whitespaces), but other than that, I would not ignore any garbage at the end... (I assume the java parser doesn't do this either)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1842
There's also this weird thing at the end of the CompilationUnit production:
I think this is meant to allow any additionnal trailing characters, but in that case it should be written
( < ~[] > )*(no quotes, a star). With the current grammar, an empty file with just the contents~[]is a valid compilation unit.