Skip to content

[core] Deprecate some more property types#1486

Merged
adangel merged 6 commits into
pmd:masterfrom
oowekyala:deprecate-intMultiProperty
Nov 30, 2018
Merged

[core] Deprecate some more property types#1486
adangel merged 6 commits into
pmd:masterfrom
oowekyala:deprecate-intMultiProperty

Conversation

@oowekyala

Copy link
Copy Markdown
Member

Takes care of

  • IntegerMultiProperty
  • DoubleProperty
  • DoubleMultiProperty

They barely had any usages so I though doing them together was ok.

I also updated the deprecated notices on Float[Multi]Property.

Refs #1432

@oowekyala oowekyala added this to the 6.10.0 milestone Nov 29, 2018
@ghost

ghost commented Nov 29, 2018

Copy link
Copy Markdown
1 Warning
⚠️ This PR cannot be merged yet.

Generated by 🚫 Danger

@adangel adangel self-assigned this Nov 30, 2018

@adangel adangel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adangel adangel merged commit 41d5281 into pmd:master Nov 30, 2018
@oowekyala oowekyala deleted the deprecate-intMultiProperty branch November 30, 2018 15:52
@oowekyala oowekyala added the is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:deprecation The main focus is deprecating public APIs or rules, eg to make them internal, or removing them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants