[apex] Fix class cast exceptions when using javadoc#1408
Merged
Conversation
* Add test cases for the affected rules * refs pmd#1396
This will visit all node types, including ASTFormalComment. No need to explicitly implement visit(ASTFormalComment) in AbstractNcssCountRule and ExcessiveNodeCountRule
Deprecate visit(ApexNode<?>)
Generated by 🚫 Danger |
64 tasks
jsotuyod
approved these changes
Oct 27, 2018
jsotuyod
left a comment
Member
There was a problem hiding this comment.
looks good, I'll fix them as I merge
|
|
||
| * all | ||
| * [#1272](https://github.com/pmd/pmd/issues/1272): \[core] Could not find or load main class when using symlinked run.sh | ||
| * [#1377](https://github.com/pmd/pmd/issues/1377): \[core] LanguageRegistry uses default class loader when invoking ServiceLocator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1396