Skip to content

[java] CompareObjectsWithEqualsRule trigger by enum1 != enum2 #885

@d1ss0nanz

Description

@d1ss0nanz

Affects PMD Version:
6.0.1

Rule:
CompareObjectsWithEquals

Description:
enum1 != enum2 triggers CompareObjectsWithEquals.
I've seen there is code in CompareObjectsWithEqualsRule.java that says "skip, if it is an enum", but it doesn't.

Code Sample demonstrating the issue:

public static void assertEquals(final Enum<?> enum1,
                                    final Enum<?> enum2,
                                    final UUID errorKey,
                                    final Object... errorArgs)
        throws ResponseException
    {
        if (enum1 != enum2)
        {
            throw new ResponseException(errorKey, errorArgs);
        }
    }

Running PMD through: [CLI | Gradle]

Metadata

Metadata

Assignees

No one assigned

    Labels

    a:false-positivePMD flags a piece of code that is not problematic

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions