Skip to content

[java] UseTryWithResources - false negative for explicit close #2882

@adangel

Description

@adangel

Affects PMD Version: 6.30.0-SNAPSHOT

Rule:UseTryWithResources

Description:

From #2871 (comment)

Code Sample demonstrating the issue:

https://chunk.io/pmd/fc7db65b2c6a46eca4c9a0c3012482e2/diff/checkstyle/index.html#A360

import java.io.*;

public class UseTryWithResources {
    void method() throws Exception {
        final String fileName = "Test";
        final BufferedReader br = new BufferedReader(new InputStreamReader(
                new FileInputStream(fileName), StandardCharsets.UTF_8));
        try { // warning expected: Consider using a try-with-resources statement instead of explicitly closing the resource 
        } finally {
            br.close();
        }
    }
}

Expected outcome:

  • Is PMD missing to report a violation, where there should be one? -> false-negative

Running PMD through: regression-tester

Metadata

Metadata

Assignees

No one assigned

    Labels

    a:false-negativePMD doesn't flag a problematic piece of code

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions