The contract of Node::getChild (#2172) is to throw when the index is out of bounds. Antlr parse trees also happen to have a getChild method whose contract is to return null in this case. Should we align ourselves? I think it's reasonable, though this needs to be pointed out in the release notes, as it's a noticeable departure from the current status quo
The contract of
Node::getChild(#2172) is to throw when the index is out of bounds. Antlr parse trees also happen to have agetChildmethod whose contract is to return null in this case. Should we align ourselves? I think it's reasonable, though this needs to be pointed out in the release notes, as it's a noticeable departure from the current status quo