Cloneable implementation draws false positives #3103

linusjf · 2021-02-06T08:28:08Z

linusjf
Feb 6, 2021

package ds;

 interface ITreeNode<E> extends Cloneable { 
ITreeNode<E> clone(); 
}

package ds; 

public class TreeNode<T extends Comparable<T>> implements ITreeNode<T> { 

 @Override public ITreeNode<T> clone() { 
try { 
return (ITreeNode<T>) super.clone(); 
} catch (CloneNotSupportedException cnse) { 
throw new AssertionError("Shouldn't reach here...", cnse); 
} 
}
 }

I have the above two classes implementing the Cloneable interface.

I have the following violations for three rules related to implementing Cloneable (line numbers are not relevant):

DSAlgos/src/main/java/ds/ITreeNode.java:36:	CloneMethodMustImplementCloneable:	clone() method should be implemented only if implementing Cloneable interface

DSAlgos/src/main/java/ds/ITreeNode.java:36:	CloneThrowsCloneNotSupportedException:	clone() method should throw CloneNotSupportedException

DSAlgos/src/main/java/ds/TreeNode.java:209:	CloneMethodReturnTypeMustMatchClassName:	The return type of the clone() method must be the class name when implements Cloneable

DSAlgos/src/main/java/ds/TreeNode.java:209:	CloneThrowsCloneNotSupportedException:	clone() method should throw CloneNotSupportedException

Should I club all these violations in one issue since they're all related despite violating three distinct rules?
Shouldn't these rules be clubbed into one?

linusjf · 2021-02-08T06:11:15Z

linusjf
Feb 8, 2021
Author

False positive (s) reported at #3104.

2 replies

oowekyala Feb 8, 2021
Maintainer

@Fernal73 please just open a bug report when you want to discuss a false positive. This is not a Q&A question.

linusjf Feb 8, 2021
Author

I agree. The Cloneable rules must be clubbed together.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Cloneable implementation draws false positives #3103

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 2 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

Cloneable implementation draws false positives #3103

Uh oh!

Uh oh!

linusjf Feb 6, 2021

Replies: 1 comment · 2 replies

Uh oh!

linusjf Feb 8, 2021 Author

Uh oh!

oowekyala Feb 8, 2021 Maintainer

Uh oh!

linusjf Feb 8, 2021 Author

linusjf
Feb 6, 2021

Replies: 1 comment 2 replies

linusjf
Feb 8, 2021
Author

oowekyala Feb 8, 2021
Maintainer

linusjf Feb 8, 2021
Author