Skip to content

Fix for #294#331

Merged
bouwew merged 9 commits intomainfrom
version_to_model
Jun 14, 2023
Merged

Fix for #294#331
bouwew merged 9 commits intomainfrom
version_to_model

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Jun 14, 2023

No description provided.

@bouwew bouwew requested a review from CoMPaTech June 14, 2023 18:07
@bouwew
Copy link
Contributor Author

bouwew commented Jun 14, 2023

Fixes #294

@bouwew bouwew marked this pull request as ready for review June 14, 2023 18:10
@bouwew bouwew requested a review from a team as a code owner June 14, 2023 18:10
CHANGELOG.md Outdated

## Ongoing

- Fix TODO #294
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably adjust to 'repair coverage/fix testing'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem.

@bouwew bouwew linked an issue Jun 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #331 (44dcc62) into main (0ce53a9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 44dcc62 differs from pull request most recent head b5edb88. Consider uploading reports for the commit b5edb88 to get more accurate results

@@            Coverage Diff            @@
##              main      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2639      2640    +1     
=========================================
+ Hits          2639      2640    +1     
Impacted Files Coverage Δ
plugwise/helper.py 100.00% <100.00%> (ø)
plugwise/util.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bouwew bouwew merged commit c3b3797 into main Jun 14, 2023
@bouwew bouwew deleted the version_to_model branch June 14, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TODO]: Mitigate coverage decrease

2 participants