Skip to content

Initial split domain structure#287

Merged
CoMPaTech merged 9 commits intomainfrom
split
Apr 17, 2023
Merged

Initial split domain structure#287
CoMPaTech merged 9 commits intomainfrom
split

Conversation

@CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Apr 10, 2023 •
edited
Loading

As per discussion on discourse:

Split functionality with 0.30 release, from that split 0.31 releases in individual repositories.

Suggested path: Core 'virtual' domain plugwise_bv (or similar) and retaining plugwise as the main integration and introduce plugwise_usb (or something similar)

@CoMPaTech CoMPaTech added enhancement New feature or request python Pull requests that update Python code labels Apr 10, 2023
@CoMPaTech
Copy link
Member Author

CoMPaTech commented Apr 10, 2023

TODO: Look up coverage of version_to_model and why it isn't covered now (+add the HW_MODELS to that test)

@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #287 (9414ecd) into main (b912cc9) will decrease coverage by 0.04%.
The diff coverage is 98.41%.

@@             Coverage Diff             @@
##              main     #287      +/-   ##
===========================================
- Coverage   100.00%   99.96%   -0.04%     
===========================================
  Files            6        8       +2     
  Lines         2680     2633      -47     
===========================================
- Hits          2680     2632      -48     
- Misses           0        1       +1
Impacted Files Coverage Δ
plugwise/smile/__init__.py 100.00% <ø> (ø)
plugwise/smile/exceptions.py 100.00% <ø> (ø)
plugwise/smile/helper.py 100.00% <ø> (ø)
plugwise/smile/util.py 98.11% <98.11%> (ø)
plugwise/smile/constants.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)
tests/test_stick.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CoMPaTech
Copy link
Member Author

CoMPaTech commented Apr 11, 2023

plugwise/python-plugwise-usb#1 seems promising

Still bugged by the codecov reduce

bouwew
bouwew reviewed Apr 13, 2023
View reviewed changes
bouwew
bouwew reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good from Smile-point-of-view.

@CoMPaTech CoMPaTech marked this pull request as ready for review April 13, 2023 09:51
@CoMPaTech CoMPaTech requested review from a team and brefra as code owners April 13, 2023 09:51
@CoMPaTech
Copy link
Member Author

CoMPaTech commented Apr 13, 2023

Suggesting to confirm if we want to split - follow-up PR should become v0.31 initially and move plugwise/smile back to plugwise/ (while removing USB/Usb-specific-Stick).

Also suggesting to move the codecov util.py towards follow-up PR

bouwew
bouwew approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@CoMPaTech
Copy link
Member Author

CoMPaTech commented Apr 13, 2023

Awaiting feedback from @brefra (via this PR or PlugwiseDevs Discord)

@CoMPaTech CoMPaTech mentioned this pull request Apr 13, 2023
Merged
@CoMPaTech CoMPaTech mentioned this pull request Apr 17, 2023
Closed
@CoMPaTech
Copy link
Member Author

CoMPaTech commented Apr 17, 2023

Merging as discussed

@CoMPaTech CoMPaTech merged commit 48e3cc0 into main Apr 17, 2023
@CoMPaTech CoMPaTech deleted the split branch April 17, 2023 18:34
This was referenced Apr 17, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bouwew bouwew bouwew approved these changes

@brefra brefra Awaiting requested review from brefra

Assignees

@CoMPaTech CoMPaTech

@bouwew bouwew

Labels

enhancement New feature or request python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CoMPaTech @bouwew