Skip to content

Try fix uv error#340

Merged
bouwew merged 2 commits intomainfrom
fix-uv
Oct 5, 2025
Merged

Try fix uv error#340
bouwew merged 2 commits intomainfrom
fix-uv

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 5, 2025

Summary by CodeRabbit

  • Chores

    • Streamlined CI bootstrap process for core testing to improve reliability and consistency. No user-facing changes.
  • Tests

    • Updated test setup to target the custom component’s setup entry point for better alignment with the integration structure.
    • Included necessary testing utilities to ensure stable test execution.
    • No behavioral changes to the integration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

CI script now invokes the HA-core bootstrap script directly instead of transforming pip commands via pipes. Tests adjust patch target to the custom component path and import MockConfigEntry from pytest_homeassistant_custom_component.

Changes

Cohort / File(s) Summary of changes
CI bootstrap invocation
scripts/ci-core-testing.sh
Replaced pip-command extraction/translation pipeline with direct execution of sh "${coredir}/script/bootstrap".
Test configuration updates
tests/conftest.py
Patched async_setup_entry via custom_components.plugwise_usb.async_setup_entry; added import for MockConfigEntry from pytest_homeassistant_custom_component.common.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant CI as CI Script (ci-core-testing.sh)
    participant Core as HA Core Bootstrap Script

    Note over CI: Previous flow
    CI->>CI: Read bootstrap file
    CI->>CI: Grep "pip install"
    CI->>CI: Replace "python3 -m pip" → "uv pip"
    CI->>Core: Pipe transformed lines to sh
    Core-->>CI: Execute inferred installs

    Note over CI,Core: New flow
    CI->>Core: sh "${coredir}/script/bootstrap"
    Core-->>CI: Run full bootstrap as-defined
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug, dependencies, github-actions

Suggested reviewers

  • ArnoutD

Poem

A rabbit taps the CI drums—thump, thump, no fuss,
Boots run straight, no pipes to twist or cuss.
Tests hop paths to custom burrows neat,
Mock entries lined like carrot treats.
With whiskered pride we ship and grin—
Less churn, more turn, let builds begin! 🥕🐇

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-uv

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6400030 and a0e8a37.

📒 Files selected for processing (2)
  • scripts/ci-core-testing.sh (1 hunks)
  • tests/conftest.py (2 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2025

@bouwew bouwew marked this pull request as ready for review October 5, 2025 08:21
@bouwew bouwew requested a review from a team as a code owner October 5, 2025 08:21
@bouwew bouwew merged commit 9bffca4 into main Oct 5, 2025
11 of 12 checks passed
@bouwew bouwew deleted the fix-uv branch October 5, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant